LGTM. I like the extensive unit test program!
http://codereview.chromium.org/405033/diff/3004/5001 File src/arm/fast-codegen-arm.cc (right): http://codereview.chromium.org/405033/diff/3004/5001#newcode253 src/arm/fast-codegen-arm.cc:253: Register scratch) { I'm not sure. It is possible to use the ip register as a fixed scratch register instead? http://codereview.chromium.org/405033/diff/3004/5001#newcode581 src/arm/fast-codegen-arm.cc:581: Move(Expression::kValue, object_slot, r0); Would it make sense to have a Move(Register dst, Slot src)? In a situation like here we could then use the stm instruction: Move(r2, object_slot, r0); __ mov(r1, Operand(key_literal->handle()); __ stm(db_w, sp, r2.bit() | r1.bit()); http://codereview.chromium.org/405033 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
