https://codereview.chromium.org/1040703003/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
https://codereview.chromium.org/1040703003/diff/1/src/arm/full-codegen-arm.cc#newcode868
src/arm/full-codegen-arm.cc:868: __ str(r0, StackOperand(variable));
On 2015/03/28 10:41:18, Dmitry Lomov (chromium) wrote:
Actually there are more usages of ip below this, see line 876.
I am a bit surprised that this change fixes anything, since currently
variables
that need hole-init are not stack allocated
Well, the test case is not really valid code (it re-assigns a const
variable), so it might well be that we get a bit confused. However, I
have verified that this change "fixes" the regression test.
https://codereview.chromium.org/1040703003/diff/1/src/arm/full-codegen-arm.cc#newcode877
src/arm/full-codegen-arm.cc:877: __ str(ip, ContextOperand(cp,
variable->index()));
On 2015/03/29 09:07:04, Benedikt Meurer (OOO) wrote:
As noted by Dmitry, this will also cause trouble if variable->index()
is too
big.
Done.
https://codereview.chromium.org/1040703003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
