http://codereview.chromium.org/443021/diff/1/2 File test/cctest/test-api.cc (right):
http://codereview.chromium.org/443021/diff/1/2#newcode8530 test/cctest/test-api.cc:8530: // Context dendent context creates reference from the compilation cache to the On 2009/11/27 07:14:45, Mads Ager wrote: > Context-dependent context data? Done. http://codereview.chromium.org/443021/diff/1/2#newcode8542 test/cctest/test-api.cc:8542: //context.MakeWeak(&got_callback, SetBooleanCallback); On 2009/11/27 07:14:45, Mads Ager wrote: > I guess this is not needed? Please remove the callback as well in that case. Done. http://codereview.chromium.org/443021/diff/1/2#newcode8544 test/cctest/test-api.cc:8544: globals = true; On 2009/11/27 07:14:45, Mads Ager wrote: > Use break in the loops instead? Done. http://codereview.chromium.org/443021/diff/1/2#newcode8549 test/cctest/test-api.cc:8549: On 2009/11/27 07:14:45, Mads Ager wrote: > You should probably check that there are no global objects at this time? Done. http://codereview.chromium.org/443021 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
