http://codereview.chromium.org/434117/diff/1/10 File src/accessors.cc (right):
http://codereview.chromium.org/434117/diff/1/10#newcode318 src/accessors.cc:318: if (!script->line_ends()->IsUndefined()) { On 2009/11/27 12:15:01, Mads Ager wrote: > Shouldn't this always be true after InitScriptLineEnds? Can we just assert that > it is not undefined? Done. http://codereview.chromium.org/434117/diff/1/3 File test/cctest/test-api.cc (right): http://codereview.chromium.org/434117/diff/1/3#newcode8559 test/cctest/test-api.cc:8559: CHECK_EQ(2, gc_count); On 2009/11/27 12:15:01, Mads Ager wrote: > Does this change fix the issue with eval? It seems that the function is still > there on the script object? It does not - I will do that in separate change. The previous check on Android was plain wrong. The reason the count is 2 here is that the compilation cache for eval only has two generations. http://codereview.chromium.org/434117 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
