Post-landing comments: nice refactoring! One test bug, and a few nits.
https://codereview.chromium.org/1046873004/diff/1/src/mips/disasm-mips.cc
File src/mips/disasm-mips.cc (right):
https://codereview.chromium.org/1046873004/diff/1/src/mips/disasm-mips.cc#newcode106
src/mips/disasm-mips.cc:106: void DecodeTypeRegisterSPECIAL(Instruction*
instr);
nit: consider naming here, maybe: DecodeTypeRegisterSpecial()
https://codereview.chromium.org/1046873004/diff/1/src/mips/simulator-mips.cc
File src/mips/simulator-mips.cc (right):
https://codereview.chromium.org/1046873004/diff/1/src/mips/simulator-mips.cc#newcode2261
src/mips/simulator-mips.cc:2261: case TRUNC_L_D: { // Mips32r2
instruction.
This comment (and many other like it need to be changed, now that we
have r6. In "the old days", this signified instructions not available on
r1 or Loongson. This could now be 'Mips32r2/r6 instruction' or
'Mips32r2+ instruction' or '>= Mips32r2 instruction'. Let's discuss, and
pick something.
https://codereview.chromium.org/1046873004/diff/1/src/mips64/simulator-mips64.cc
File src/mips64/simulator-mips64.cc (right):
https://codereview.chromium.org/1046873004/diff/1/src/mips64/simulator-mips64.cc#newcode2409
src/mips64/simulator-mips64.cc:2409: case ROUND_L_D: { // Mips64r2
instruction.
As mentioned in simulator-mips.cc: this is for mips64r2 and r6.
https://codereview.chromium.org/1046873004/diff/1/test/cctest/test-assembler-mips.cc
File test/cctest/test-assembler-mips.cc (right):
https://codereview.chromium.org/1046873004/diff/1/test/cctest/test-assembler-mips.cc#newcode52
test/cctest/test-assembler-mips.cc:52: CcTest::InitializeVM();
Test needs to be run only on mips32r6 - it uses r6-specific
instructions.
https://codereview.chromium.org/1046873004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
