Rebased. Comments addressed. Promoting from WIP to solution. PTAL.
https://codereview.chromium.org/989123003/diff/20001/src/compiler/instruction-selector.cc
File src/compiler/instruction-selector.cc (right):
https://codereview.chromium.org/989123003/diff/20001/src/compiler/instruction-selector.cc#newcode741
src/compiler/instruction-selector.cc:741: return VisitIfException(node);
On 2015/03/10 09:42:08, Benedikt Meurer (OOO) wrote:
MarkAsReference is missing.
Done.
https://codereview.chromium.org/989123003/diff/20001/src/compiler/typer.cc
File src/compiler/typer.cc (left):
https://codereview.chromium.org/989123003/diff/20001/src/compiler/typer.cc#oldcode258
src/compiler/typer.cc:258: INNER_CONTROL_OP_LIST(DECLARE_CASE)
On 2015/03/17 16:11:32, titzer wrote:
I like expanding the INNER_CONTROL_OP_LIST but can't we get rid of
these two
methods? AFAICT, the Reduce method essentially just wraps a call to
TypeNode()
with an UpdateBounds(). Seems dumb.
Acknowledged. Happy to do that, would it be OK with you if I do that in
a follow-up CL?
https://codereview.chromium.org/989123003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
