LGTM (modulo Win failures as discussed offline).
https://codereview.chromium.org/1048063002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/1048063002/diff/1/src/hydrogen.cc#newcode12049
src/hydrogen.cc:12049: CHECK_BAILOUT(Visit(call->arguments()->at(0)));
nit: Not that it matters much, but I don't think we need the
CHECK_BAILOUT at tail positions.
https://codereview.chromium.org/1048063002/diff/1/test/unittests/compiler/js-intrinsic-lowering-unittest.cc
File test/unittests/compiler/js-intrinsic-lowering-unittest.cc (right):
https://codereview.chromium.org/1048063002/diff/1/test/unittests/compiler/js-intrinsic-lowering-unittest.cc#newcode263
test/unittests/compiler/js-intrinsic-lowering-unittest.cc:263:
ASSERT_TRUE(BranchHint::kNone == BranchHintOf(d.branch->op()));
nit: ASSERT_EQ
https://codereview.chromium.org/1048063002/diff/1/test/unittests/compiler/js-intrinsic-lowering-unittest.cc#newcode266
test/unittests/compiler/js-intrinsic-lowering-unittest.cc:266:
ASSERT_TRUE(input->op()->Equals(r.replacement()->op()));
nit: EXPECT_THAT(r.replacement(), input)
https://codereview.chromium.org/1048063002/diff/1/test/unittests/compiler/js-intrinsic-lowering-unittest.cc#newcode267
test/unittests/compiler/js-intrinsic-lowering-unittest.cc:267:
ASSERT_TRUE(BranchHint::kTrue == BranchHintOf(d.branch->op()));
nit: EXPECT_EQ
https://codereview.chromium.org/1048063002/diff/1/test/unittests/compiler/js-intrinsic-lowering-unittest.cc#newcode357
test/unittests/compiler/js-intrinsic-lowering-unittest.cc:357:
ASSERT_TRUE(BranchHint::kNone == BranchHintOf(d.branch->op()));
nit: Same as the three comments above.
https://codereview.chromium.org/1048063002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
