On 2015/03/31 18:47:48, Dmitry Lomov (chromium) wrote:
On 2015/03/31 18:19:32, adamk wrote:
> Where's the Blink side of this change?
I'll get to it once this rolls.
>
> https://codereview.chromium.org/1041863002/diff/20001/src/parser.cc
> File src/parser.cc (right):
>
>
https://codereview.chromium.org/1041863002/diff/20001/src/parser.cc#newcode2275
> src/parser.cc:2275: ++use_counts_[v8::Isolate::kLegacyConst];
> Counting each const in a script separately seems a bit odd, especially
since
> Blink will collapse all these into one. But I guess that's not
particularly
> problematic. Just wondering if it's intentional that the V8 API for
UseCounters
> doesn't match how they're used in Blink.
Yes, it is intentional. Embedder is free to collapse use counters in any
way
it
wants, we still report every usage.
Okay, thanks for the confirmation.
https://codereview.chromium.org/1041863002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.