On 2015/04/09 15:25:23, caitp wrote:
On 2015/04/09 14:46:24, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
> v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/4599)
It seems that old code-space is larger on arm64 with this flag enabled,
because
Object.prototype.toString is replaced, and the arithmetic just works out
that
way with this replacement on ARM.
So, a bit more work, but ObjectToString needs to be not installed if this
flag
is flipped on.
I've updated the code so that it doesn't "replace" an old property (makes
harmony-tostring.js a bit smaller, and v8natives.js/runtime-internal.cc
slightly
bigger), but it fixes the test failure...
Sigh, it's getting a bit big for a "flip the switch" patch :| think I
prefer to
move these extra changes into a separate CL which can land first, so that
it's
easier to revert if necessary
https://codereview.chromium.org/1072573002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
