please take another look
https://codereview.chromium.org/985023002/diff/20001/src/compiler/visualizer.cc
File src/compiler/visualizer.cc (right):
https://codereview.chromium.org/985023002/diff/20001/src/compiler/visualizer.cc#newcode824
src/compiler/visualizer.cc:824: std::ostream& operator<<(std::ostream&
os, const ScheduleAsJSON& aj) {
On 2015/03/06 17:51:55, Michael Starzinger wrote:
Why is this called ScheduleAsJSON, there doesn't seem to anything JSON
specific
in here, this is the same operator that is used to just print to the
schedule.
Also why do we need to move it into the visualizer.cc file, I think it
belongs
in either schedule.cc as it was before.
Done.
https://codereview.chromium.org/985023002/diff/20001/src/compiler/visualizer.cc#newcode849
src/compiler/visualizer.cc:849: SourcePosition p =
aj.positions->GetSourcePosition(node);
On 2015/03/06 17:51:55, Michael Starzinger wrote:
I assume the visualizer parses these source position annotations.
Correct? Would
it be possible to have that as a side-table, outside of the scheduler
printout?
Done.
https://codereview.chromium.org/985023002/diff/20001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):
https://codereview.chromium.org/985023002/diff/20001/tools/gyp/v8.gyp#newcode545
tools/gyp/v8.gyp:545: '../../src/compiler/visualizer.cc',
On 2015/03/06 17:51:56, Michael Starzinger wrote:
Please also adapt BUILD.gn on the top level.
Done.
https://codereview.chromium.org/985023002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
