Thanks. This doesn't fix the VFP3 vs VFPv2 issue from http://code.google.com/p/v8/issues/detail?id=512 but that can be fixed in a separate change. Otherwise looks good to me apart from the two issues below.
http://codereview.chromium.org/464016/diff/1/2 File AUTHORS (right): http://codereview.chromium.org/464016/diff/1/2#newcode23 AUTHORS:23: Subrato K De <[email protected]> Since you are corporate contributors, your name and John's should be removed and instead Code Aurora should be added after Google Inc. http://codereview.chromium.org/464016/diff/1/4 File src/arm/assembler-arm.h (right): http://codereview.chromium.org/464016/diff/1/4#newcode108 src/arm/assembler-arm.h:108: struct S_VFP_Register { This doesn't follow the naming convention:http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Type_Names#Type_Names http://codereview.chromium.org/464016 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
