On 2015/04/14 16:35:24, paul.l... wrote:
On 2015/04/14 09:41:57, Jakob wrote:
> MIPS: This is ready for landing, please be so kind to prepare the ports.
Jakob, with this CL on ToT now, with the flag on, there are lots of
crashes in
release mode, and asserts hit in debug (ia32 & x64):
# Fatal error in .././src/objects-inl.h, line 3427
# Check failed: !v8::internal::FLAG_enable_slow_asserts ||
(object->IsPrototypeInfo()).
one example: test/mjsunit/with-function-expression.js
So we can test without the flag, but most of the new code is behind the
flag.
Thanks for the heads-up; that's not intended. I ran tests with the flag on
earlier today and didn't see any failures. I'll investigate tomorrow.
While writing this, I had an idea: did you pass the flag on the
command-line?
Unfortunately that's not supported, as code in the snapshot has to agree
with
code generated later. So to toggle the flag you'll have to edit
flag-definitions.h and recompile V8. Does that fix the failures you were
seeing?
The plan is to land the CL with the flag off first, and then turn it on soon
after (as soon as the buildbots are green, probably), so that reverting is
easy.
So for now, tests should pass both with and without the flag.
https://codereview.chromium.org/908213002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
