Reviewers: Yang,

Message:
PTAL.

Description:
Bump limit in PushStackTraceAndDie

To increase the chances of minidumps containing enough useful information

[email protected]

Please review this at https://codereview.chromium.org/1068783006/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+1, -1 lines):
  M src/isolate.cc


Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 1edae6b61e4e98f7e112e0e9824f58806ba39d08..9c4bc52288c84c02753d8e9d529a109eb916badc 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -285,7 +285,7 @@ void Isolate::PushStackTraceAndDie(unsigned int magic,
                                    Object* object,
                                    Map* map,
                                    unsigned int magic2) {
-  const int kMaxStackTraceSize = 8192;
+  const int kMaxStackTraceSize = 32 * KB;
   Handle<String> trace = StackTraceString();
   uint8_t buffer[kMaxStackTraceSize];
   int length = Min(kMaxStackTraceSize - 1, trace->length());


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to