LGTM. It's a wart that 'this' is a Variable at all since it's a keyword in the syntax and it's treated as an exception in the code more often than it's treated as a normal variable. We should just change that.
http://codereview.chromium.org/464069/diff/1/2 File src/compiler.cc (right): http://codereview.chromium.org/464069/diff/1/2#newcode59 src/compiler.cc:59: ASSERT_EQ(Expression::kUninitialized, expr->context()); As we discussed, change this to ASSERT(expr->context() == Expression::kUninitialzed || expr->context() == context); http://codereview.chromium.org/464069 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
