Drive by comments.


http://codereview.chromium.org/463040/diff/5/1004
File test/mjsunit/object-create.js (right):

http://codereview.chromium.org/463040/diff/5/1004#newcode43
test/mjsunit/object-create.js:43: var Foo = { foo: function() { ctr++;
}};
It's still not traditional JS notation to uppercase prototypes. How
about calling it "protoFoo"?

http://codereview.chromium.org/463040/diff/5/1004#newcode184
test/mjsunit/object-create.js:184: print("ok");
Please don't do (permanent) workarounds for the non-optimizing compiler.
It will, eventually, support the full syntax, so unless you expect to go
back and change this when it happens, just write it correctly now.
(If anything, you can wrap the test in a function and call the function
in a catch, and then run with --always-fast-compiler, so the function is
compiled with the fast compiler.)

http://codereview.chromium.org/463040

-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to