detectReverts.py -> detect_reverts.py
Please be more pedantic about style as long as there is no automation for
it,
e.g. spaces, indentation and var names. I commented on a few.
https://codereview.chromium.org/1098123002/diff/1/tools/release/detectReverts.py
File tools/release/detectReverts.py (right):
https://codereview.chromium.org/1098123002/diff/1/tools/release/detectReverts.py#newcode12
tools/release/detectReverts.py:12: def print_analysis(gitWorkingDir,
hashToSearch, upperBound):
nit: python var names
https://codereview.chromium.org/1098123002/diff/1/tools/release/detectReverts.py#newcode14
tools/release/detectReverts.py:14: raw_output =
git_execute(gitWorkingDir, ["rev-list", hashToSearch + ".." +
upperBound])
Suggestiong: you could use log on origin/master with --grep="[Rr]evert
XXX" and --format=%H
XXX stands for the way numbers or hashes would be regexped in grep -
don't recall that right now.
Then you have everything in one git call.
https://codereview.chromium.org/1098123002/diff/1/tools/release/detectReverts.py#newcode18
tools/release/detectReverts.py:18: candidate_hashes =
raw_output.split("\n")
splitlines()
https://codereview.chromium.org/1098123002/diff/1/tools/release/detectReverts.py#newcode28
tools/release/detectReverts.py:28:
nit: two empty lines between things on toplevel
https://codereview.chromium.org/1098123002/diff/1/tools/release/detectReverts.py#newcode29
tools/release/detectReverts.py:29: def git_execute(workingDir,
commands):
working_dir
https://codereview.chromium.org/1098123002/diff/1/tools/release/detectReverts.py#newcode39
tools/release/detectReverts.py:39: parser =
argparse.ArgumentParser('Tool to check where a git commit was merged and
reverted.')
Is a tool for one commit useful? Why not a whole range of commits? E.g.
B is branch point. Tell me if there's anything interesting about commits
in A..B within the range B..C (where C might be HEAD) and where A might
be the a commit a week ago.
https://codereview.chromium.org/1098123002/diff/1/tools/release/detectReverts.py#newcode41
tools/release/detectReverts.py:41: help="The path to your git working
directory.")
nit: indentation
https://codereview.chromium.org/1098123002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
