LGTM!
http://codereview.chromium.org/467037/diff/1/7 File src/heap.cc (right): http://codereview.chromium.org/467037/diff/1/7#newcode4060 src/heap.cc:4060: List<Object*>& target = new_to_old ? old_space_strings_ : new_space_strings_; Use old_space_strings_ as the target always? It should be completely clear that this can only ever move from the new space list to the old space list. It might be clearer to remove the bool parameter and just iterate new_space_strings first and then iterate old_space_strings? It is a bit more code, but I think it would be clearer and it would remove checking for new space for old_space_strings. http://codereview.chromium.org/467037 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
