Looks good to me. I will commit this in the morning so there is someone around if it breaks something and we have to revert.
http://codereview.chromium.org/464070/diff/16/20 File SConstruct (right): http://codereview.chromium.org/464070/diff/16/20#newcode667 SConstruct:667: 'values': ['arm', 'thumb', 'none'], Can we rename the option from thumb to thumb2 and change from variant to armvariant? Also above where the macro is defined. The thumb instruction set is a different and altogether less useful one. http://codereview.chromium.org/464070/diff/16/20#newcode669 SConstruct:669: 'help': 'generate thumb2 instructions instead of arm instructions' Can we add (default) at the end of this string, since otherwise it's not clear what the default is on an ARM target. http://codereview.chromium.org/464070 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
