On 2015/03/19 20:33:21, caitp wrote:
On 2015/03/19 20:30:15, arv wrote:
> On 2015/03/19 19:42:10, caitp wrote:
> >
>
https://codereview.chromium.org/1011823003/diff/1/test/webkit/preventExtensions.js
> > File test/webkit/preventExtensions.js (right):
> >
> >
>
https://codereview.chromium.org/1011823003/diff/1/test/webkit/preventExtensions.js#newcode96
> > test/webkit/preventExtensions.js:96: shouldBe('"use strict"; var o =
{};
> > Object.preventExtensions(o); o.__proto__ = { newProp: "Should not see
this"
};
> > o.newProp;');
> > On 2015/03/19 19:38:08, arv wrote:
> > > This should still throw, shouldn't it?
> >
> > Yeah. I passed make check, but I guess the WebKit tests aren't run
that
way.
> > I'll you're both of these tonight
>
> tools/run-tests.py --mode release --arch x64 webkit
Yeah, it looks safe to leave the WebKit tests as they were, they are
correct.
All fixed up, passing locally. Just maybe test262 statuses need an update
ping arv@ --- kind of forgot about this one, but it seems trivial
https://codereview.chromium.org/1011823003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
