https://codereview.chromium.org/1065983005/diff/1/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1065983005/diff/1/src/preparser.h#newcode578
src/preparser.h:578: class ExpressionClassifier {
On 2015/04/22 09:30:47, rossberg wrote:
Don't we also want is_valid_arrow_parameter_list, to generalise the
current
hacks around that?
Sounds good, but I'd prefer to do that in a separate CL.
https://codereview.chromium.org/1065983005/diff/1/src/preparser.h#newcode2028
src/preparser.h:2028: #define CHECK_CLASSIFIER_OK classifier, ok); \
On 2015/04/22 09:30:47, rossberg wrote:
Don't think this macro is worth it. It saves a single character, which
doesn't
justify the added obscurity and irregularity...
Unless you plan to merge the ok into the classifier. Not sure if
that's
desirable?
Yes, I think we should merge ok into a classifier - does not make sense
to have both. But I'd perfer to do that in a separate CL as well.
https://codereview.chromium.org/1065983005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
