Thanks. Comments addressed (also on x64/arm).
http://codereview.chromium.org/465148/diff/1/2 File src/ia32/fast-codegen-ia32.cc (right): http://codereview.chromium.org/465148/diff/1/2#newcode659 src/ia32/fast-codegen-ia32.cc:659: // Registers will be used as follows: On 2009/12/09 12:50:07, Kevin Millikin wrote: > This comment seems unnecessary (and no longer accurate). Done. http://codereview.chromium.org/465148/diff/1/2#newcode666 src/ia32/fast-codegen-ia32.cc:666: __ push(ebx); On 2009/12/09 12:50:07, Kevin Millikin wrote: > Can you just push(FieldOperand(edi, JSFunction::kLiteralsOffset))? Done. http://codereview.chromium.org/465148/diff/1/2#newcode774 src/ia32/fast-codegen-ia32.cc:774: __ push(ebx); On 2009/12/09 12:50:07, Kevin Millikin wrote: > Same. Done. http://codereview.chromium.org/465148/diff/1/3 File src/runtime.cc (right): http://codereview.chromium.org/465148/diff/1/3#newcode416 src/runtime.cc:416: return DeepCopyBoilerplate(static_cast<JSObject*>(*boilerplate)); On 2009/12/09 12:50:07, Kevin Millikin wrote: > Not static_cast<JSObject*>(*boilerplate), but JSObject::cast(*boilerplate). Done. http://codereview.chromium.org/465148 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
