lgtm. Great stuff, thanks for doing this!
https://codereview.chromium.org/1106613003/diff/1/src/compiler/js-intrinsic-lowering.cc
File src/compiler/js-intrinsic-lowering.cc (right):
https://codereview.chromium.org/1106613003/diff/1/src/compiler/js-intrinsic-lowering.cc#newcode162
src/compiler/js-intrinsic-lowering.cc:162: // TODO(bmeurer): if
(!FLAG_turbo_deoptimization) return NoChange();
I think we should keep the check here, so that we do not crash on
clusterfuzz. (This basically means ignoring the deoptimization.)
https://codereview.chromium.org/1106613003/diff/1/src/compiler/js-typed-lowering.cc
File src/compiler/js-typed-lowering.cc (right):
https://codereview.chromium.org/1106613003/diff/1/src/compiler/js-typed-lowering.cc#newcode214
src/compiler/js-typed-lowering.cc:214: // TODO(bmeurer): if
(!FLAG_turbo_deoptimization) return nullptr;
Remove the TODO and perhaps consider short-circuiting for
BailoutId::None (just like the CreateFrameStateForRightInput method).
https://codereview.chromium.org/1106613003/diff/1/src/compiler/js-typed-lowering.cc#newcode237
src/compiler/js-typed-lowering.cc:237: // TODO(bmeurer): if
(!FLAG_turbo_deoptimization) return nullptr;
Remove the TODO.
https://codereview.chromium.org/1106613003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
