Reviewers: adamk, caitp,
Message:
Created Revert of [es6] Map/Set size getter should have "get size" name
Description:
Revert of [es6] Map/Set size getter should have "get size" name (patchset #4
id:80001 of https://codereview.chromium.org/1094323005/)
Reason for revert:
Breaks GCMole ia32
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gcmole/builds/1685/steps/GCMole%20ia32/logs/stdio
src/runtime/runtime-function.cc:96:3: warning: Possible problem with
evaluation
order.
f->shared()->set_name(*NameToFunctionName(name));
^
src/runtime/runtime-function.cc:96:3: warning: Possible problem with
evaluation
order.
2 warnings generated.
Original issue's description:
[es6] Map/Set size getter should have "get size" name
Getter and setter function names in ES6 are defined as "get foo" and
"set foo".
BUG=None
LOG=N
[email protected]
Committed: https://crrev.com/83c89a2e71a363afb35595f903423e650d788e42
Cr-Commit-Position: refs/heads/master@{#28034}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Please review this at https://codereview.chromium.org/1106713002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -60 lines):
M src/runtime/runtime-function.cc
M src/v8natives.js
D test/mjsunit/es6/built-in-accessor-names.js
M test/mjsunit/es6/collections.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
