On 2015/04/23 14:11:52, wingo wrote:
No idea why these checks are causing warnings and the above "if
(value==0) {}"
check isn't, but so it is. [...]
The DCHECK_FOO macros are totally fragile because they highly depend on the
complex interaction between integral promotion, candidate selection during
overload resolution and normal functions "winning" over templates (even
when
they are fully specialized), see e.g.
http://en.cppreference.com/w/cpp/language/overload_resolution. We regularly
have
trouble with them.
My personal opinion here is: Nuke this complete nonsense, it just doesn't
work
reliably. Simple DCHECK (without any _EQ, _NE etc. suffix) is all you need
and
all that is reliable. Sadly enough, our presubmit.py thinks
differently... :-P
https://codereview.chromium.org/1105653002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
