Reviewers: Michael Achenbach,
Message:
PTAL. This reduces runtime of the "unittests" suite from ~50sec to ~15sec
on my
machine. The following is the situation ...
Before:
[00:51|% 100|+ 9432|- 0]: Done
After:
[00:13|% 100|+ 2358|- 0]: Done
Description:
[test] Limit "unittests" suite to default variant.
This changes the unittests suite to be run in only the default variant,
because unit tests are (and should be) written to be independent from
global flags.
[email protected]
Please review this at https://codereview.chromium.org/1067863007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -0 lines):
M tools/testrunner/local/testsuite.py
Index: tools/testrunner/local/testsuite.py
diff --git a/tools/testrunner/local/testsuite.py
b/tools/testrunner/local/testsuite.py
index
7fea13a4ae3683a19fadab9475ecde9621852ac4..0b38d8c0386af39208e5925bf656e83c6f340cbb
100644
--- a/tools/testrunner/local/testsuite.py
+++ b/tools/testrunner/local/testsuite.py
@@ -272,5 +272,8 @@ class GoogleTestSuite(TestSuite):
["--gtest_print_time=0"] +
context.mode_flags)
+ def VariantFlags(self, testcase, default_flags):
+ return [[]]
+
def shell(self):
return self.name
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
