Looks good. I see SecondaryField param is used in min, max too, but it is a
nit
for me:
https://codereview.chromium.org/1108583003/diff/1/src/mips/assembler-mips.h
File src/mips/assembler-mips.h (right):
https://codereview.chromium.org/1108583003/diff/1/src/mips/assembler-mips.h#newcode915
src/mips/assembler-mips.h:915: void rint(SecondaryField fmt, FPURegister
fd, FPURegister fs);
I think rint_s() and rint_d() should be implemented instead of using
SecondaryField param to match to all the other instructions.
https://codereview.chromium.org/1108583003/diff/1/src/mips64/assembler-mips64.h
File src/mips64/assembler-mips64.h (right):
https://codereview.chromium.org/1108583003/diff/1/src/mips64/assembler-mips64.h#newcode945
src/mips64/assembler-mips64.h:945: void rint(SecondaryField fmt,
FPURegister fd, FPURegister fs);
I think rint_s() and rint_d() should be implemented instead of using
SecondaryField param to match to all the other instructions.
https://codereview.chromium.org/1108583003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
