No cctests?
Your CL descriptions mentions unary + but not unary -. Fine to split them
up as
you wish.
https://codereview.chromium.org/1102923002/diff/60001/src/compiler/js-typed-lowering.cc
File src/compiler/js-typed-lowering.cc (right):
https://codereview.chromium.org/1102923002/diff/60001/src/compiler/js-typed-lowering.cc#newcode362
src/compiler/js-typed-lowering.cc:362: if
(r.BothInputsAre(Type::Number())) {
Let me make sure I understand this. If the operands are not numbers we
keep the nodes which will cause the runtime call which will throw?
https://codereview.chromium.org/1102923002/diff/60001/test/mjsunit/strong/implicit-conversions.js
File test/mjsunit/strong/implicit-conversions.js (right):
https://codereview.chromium.org/1102923002/diff/60001/test/mjsunit/strong/implicit-conversions.js#newcode10
test/mjsunit/strong/implicit-conversions.js:10: let strong_binops = [
FYI. Our js style does not allow underscores in variable names. I know
the V8 team has historically been opposed to follow the google style
guide though...
https://codereview.chromium.org/1102923002/diff/60001/test/mjsunit/strong/implicit-conversions.js#newcode108
test/mjsunit/strong/implicit-conversions.js:108: function not_strong(x,
y) {
Not clear why you need this function. You are testing the unary ops
later.
https://codereview.chromium.org/1102923002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
