No, preventing optimization of functions that throw is definitely not the right approach.
I haven't looked at the situation in more detail though, so I don't know what the problem is and how to fix it. Yang (+CC) might know more. On Sat, Apr 25, 2015 at 5:45 AM, Ankur Verma <[email protected]> wrote: > Hello, > Pls have a look at this issue for details: > http://code.google.com/p/chromium/issues/detail?id=430528 > > On analysis of the issue, the problem appears when the runtime profiler > tries to optimize a function which had actually thrown an exception during > execution. This messes the reference for built-in function GetLineNumber > thus causing the bug. > A simple solution I have is to mark the functions which caused an > exception during execution as non-optimizable. This works with all tests > passing. But I am fairly new to V8 and would this like to know if this is a > correct approach or not. I would like to submit a patch if this seems > sensible. > Thanks, > Ankur > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
