On 2015/04/27 10:23:53, conradw wrote:
https://codereview.chromium.org/1084243005/diff/1/src/compiler/js-operator.cc
File src/compiler/js-operator.cc (right):
https://codereview.chromium.org/1084243005/diff/1/src/compiler/js-operator.cc#newcode281
src/compiler/js-operator.cc:281: Name##Operator<STRICT>
k##Name##StrictOperator;
\
This change means that operators which behave identically in sloppy and
strict
mode have separate cached versions for the two modes. This seems odd,
especially
since Store only caches sloppy and strict versions. Also, as it stands
currently, none of the strict cached operators here are ever used by any
code.
Yes. That's actually intentional. Otherwise you'll get odd behavior, i.e.
OpParameter<LanguageMode>(javascript()->Operator(STRICT)) != STRICT
which I'm sure will cause trouble at some point, and is completely weird.
https://codereview.chromium.org/1084243005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
