Thanks for the review :) I've tested the perf locally on code-load and it
looks
good, but let's keep an eye on the perf bots too.
https://codereview.chromium.org/1110473003/diff/20001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1110473003/diff/20001/src/parser.cc#newcode993
src/parser.cc:993: // Enter 'scope' with the given parsing mode..
On 2015/04/27 10:44:03, Michael Starzinger wrote:
nit: One dot oughta be enough for everyone.
Done.
https://codereview.chromium.org/1110473003/diff/20001/src/parser.cc#newcode1273
src/parser.cc:1273: if (scope_->is_eval_scope()) mode_ = PARSE_EAGERLY;
On 2015/04/27 10:44:03, Michael Starzinger wrote:
nit: Needs a comment.
Done, though it's speculation to an extent; it replicates the original
logic but that didn't have a comment either. Commenting out line 1280
causes the mentioned test to fail though, so there is that.
https://codereview.chromium.org/1110473003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
