LGTM

http://codereview.chromium.org/489005/diff/3001/4003
File src/debug.cc (right):

http://codereview.chromium.org/489005/diff/3001/4003#newcode2487
src/debug.cc:2487: // Simply ignore message.
Maybe this should be extended to keep all messages (or block on the
first) for the debugger when it connects in a future changelist.

http://codereview.chromium.org/489005/diff/3001/4003#newcode2493
src/debug.cc:2493: if (wait_for_connection) {
You should rephrase this comment to say that a break is actually set.

http://codereview.chromium.org/489005

-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to