LGTM with nits.
https://codereview.chromium.org/1060583008/diff/1/src/messages.h
File src/messages.h (right):
https://codereview.chromium.org/1060583008/diff/1/src/messages.h#newcode99
src/messages.h:99: int GetLineNumber(Isolate* isolate);
To prevent future confusion, let's add a comment stating that the result
is 1-based.
https://codereview.chromium.org/1060583008/diff/1/test/mjsunit/compiler/regress-stacktrace.js
File test/mjsunit/compiler/regress-stacktrace.js (right):
https://codereview.chromium.org/1060583008/diff/1/test/mjsunit/compiler/regress-stacktrace.js#newcode43
test/mjsunit/compiler/regress-stacktrace.js:43: print(stack);
nit: debugging leftover?
https://codereview.chromium.org/1060583008/diff/1/test/mjsunit/compiler/regress-stacktrace.js#newcode52
test/mjsunit/compiler/regress-stacktrace.js:52: print(stack);
nit: while you're here, delete this too?
https://codereview.chromium.org/1060583008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
