PTAL
https://codereview.chromium.org/1098123002/diff/100001/tools/release/search_related_commits.py
File tools/release/search_related_commits.py (right):
https://codereview.chromium.org/1098123002/diff/100001/tools/release/search_related_commits.py#newcode16
tools/release/search_related_commits.py:16: hash = of
On 2015/04/27 13:09:43, Michael Achenbach wrote:
not liked
Done.
https://codereview.chromium.org/1098123002/diff/100001/tools/release/search_related_commits.py#newcode43
tools/release/search_related_commits.py:43: hash = of
On 2015/04/27 13:09:43, Michael Achenbach wrote:
not liked
Done.
https://codereview.chromium.org/1098123002/diff/100001/tools/release/search_related_commits.py#newcode67
tools/release/search_related_commits.py:67: git_working_dir, (
On 2015/04/27 13:09:43, Michael Achenbach wrote:
You don't need additional parentheses in python as long as you are in
the scope
of one opening parenthesis.
Done.
https://codereview.chromium.org/1098123002/diff/100001/tools/release/search_related_commits.py#newcode143
tools/release/search_related_commits.py:143: def
_pretty_print_entry(hash, pre_text, verbose):
On 2015/04/27 13:09:43, Michael Achenbach wrote:
Format and readability - how about:
output = _git_execute(
options.git_dir,
["show",
"--quiet",
"--date=iso",
"--format=%ad # %H # %s",
hash],
verbose,
)
print pre_text + output.strip()
Done.
https://codereview.chromium.org/1098123002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
