Reviewers: Peter Rybin, Description: Reverted r3457
Caused compilation errors in cctests and on ARM platform. [email protected] Please review this at http://codereview.chromium.org/491074 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M include/v8-debug.h M src/api.cc M src/debug.h M src/debug.cc Index: include/v8-debug.h =================================================================== --- include/v8-debug.h (revision 3457) +++ include/v8-debug.h (working copy) @@ -258,11 +258,8 @@ * supplied TCP/IP port for remote debugger connection. * \param name the name of the embedding application * \param port the TCP/IP port to listen on - * \param wait_for_connection whether V8 should pause on a first breakpoint - * allowing remote debugger to connect before anything interesting happened */ - static bool EnableAgent(const char* name, int port, - bool wait_for_connection = false); + static bool EnableAgent(const char* name, int port); }; Index: src/api.cc =================================================================== --- src/api.cc (revision 3457) +++ src/api.cc (working copy) @@ -3741,8 +3741,8 @@ } -bool Debug::EnableAgent(const char* name, int port, bool wait_for_connection) { - return i::Debugger::StartAgent(name, port, wait_for_connection); +bool Debug::EnableAgent(const char* name, int port) { + return i::Debugger::StartAgent(name, port); } #endif // ENABLE_DEBUGGER_SUPPORT Index: src/debug.h =================================================================== --- src/debug.h (revision 3457) +++ src/debug.h (working copy) @@ -636,7 +636,7 @@ bool* pending_exception); // Start the debugger agent listening on the provided port. - static bool StartAgent(const char* name, int port, bool wait_for_connection); + static bool StartAgent(const char* name, int port); // Stop the debugger agent. static void StopAgent(); Index: src/debug.cc =================================================================== --- src/debug.cc (revision 3457) +++ src/debug.cc (working copy) @@ -2483,24 +2483,7 @@ } -static void StubMessageHandler2(const v8::Debug::Message& message) { - // Simply ignore message. -} - - -bool Debugger::StartAgent(const char* name, int port, - bool wait_for_connection) { - if (wait_for_connection) { - // Suspend V8 if it is already running or set V8 to suspend whenever - // it starts. - // Provide stub message handler; V8 auto-continues each suspend - // when there is no message handler; we doesn't need it. - // Once become suspended, V8 will stay so indefinitely long, until remote - // debugger connects and issues "continue" command. - Debugger::message_handler_ = StubMessageHandler2; - v8::Debug::DebugBreak(); - } - +bool Debugger::StartAgent(const char* name, int port) { if (Socket::Setup()) { agent_ = new DebuggerAgent(name, port); agent_->Start(); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
