On 2015/04/29 20:55:12, brucedawson wrote:
This change makes kUninitialized and kUndefined have the same value, where
they
used to be distinct. I noticed this because the /analyze builder gave a
new
warning pointing out that there was some redundant code. The warning is:
src\v8\src\objects.cc(17173) : warning C6287: Redundant code: the left
and
right sub-expressions are identical.
The code is this:
if ((old_type == PropertyCellType::kUninitialized ||
old_type == PropertyCellType::kUndefined) &&
value->IsString()) {
This isn't necessarily a bug but I wanted to point it out. If nothing
else the
code is now confusing. FWIW.
thanks, will fix
https://codereview.chromium.org/1102543002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
