On 2015/05/01 14:09:30, arv wrote:
Europe is on vacation today.
I'm looking at the spec for this and I feel like there are few parts
missing
here
- The spec covers the case where the type changes, as in:
UInt32Array.prototype.slice.call(int32ArrayInstance, start, end)
- I don't see @@species in here? If we write new methods we should do them
right
from the beginning.
- I don't see code checking for detached buffer?.
Does V8 have a concept of a detached buffer currently? I was looking at this
last week and it didn't look like it was needed yet
https://codereview.chromium.org/1113363002/diff/1/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1113363002/diff/1/src/typedarray.js#newcode151
src/typedarray.js:151: if (!(%_ClassOf(this) === 'NAME')) {
This is not quite right. We need to use ValidateTypeArray here.
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-validatetypedarray
https://codereview.chromium.org/1113363002/diff/1/test/mjsunit/harmony/typedarrays.js
File test/mjsunit/harmony/typedarrays.js (right):
https://codereview.chromium.org/1113363002/diff/1/test/mjsunit/harmony/typedarrays.js#newcode124
test/mjsunit/harmony/typedarrays.js:124: var a1 = new
Uint32Array(initialLen);
Maybe pass the constructor to this function so that we can test more than
Uint32Array?
https://codereview.chromium.org/1113363002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
