Reviewers: brettw, Michael Achenbach,
Description:
Adjust the visibility of the standalone targets in the GN build.
As part of the migration from GYP->GN, we want to make sure that we
can track when new targets are added to either the GYP or GN builds
and that we are building everything we expect to build.
In GN, unlike GYP, if a build file gets referenced from other files,
building 'all' will cause every target to be built in it. This means in
particular, that we can end up trying to build targets that are not
necessarily intended to be visible to the rest of the build. To get
around this, any target that is defined but hidden (like 'v8_snapshot',
in V8's case) should still be visible to a top-level target called
"//:gn_visibility".
[email protected], [email protected]
BUG=461019461019461019461019
Please review this at https://codereview.chromium.org/1120093005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+10, -2 lines):
M BUILD.gn
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index
64d75020051038fb7ba03f3f6eed9de9340af3b3..276be487aabb49c328bbbb6aea9c0d69e4f5c4d6
100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -338,7 +338,11 @@ if (v8_use_external_startup_data) {
}
action("postmortem-metadata") {
- visibility = [ ":*" ] # Only targets in this file can depend on this.
+ # Only targets in this file and top-level targets can depend on this
+ visibility = [
+ ":*",
+ "//:*",
+ ]
script = "tools/gen-postmortem-metadata.py"
@@ -423,7 +427,11 @@ source_set("v8_nosnapshot") {
}
source_set("v8_snapshot") {
- visibility = [ ":*" ] # Only targets in this file can depend on this.
+ # Only targets in this file and top-level targets can depend on this
+ visibility = [
+ ":*",
+ "//:*",
+ ]
deps = [
":js2c",
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
