LGTM with one comments to address.
https://codereview.chromium.org/1122083002/diff/1/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/1122083002/diff/1/src/isolate.cc#newcode1046
src/isolate.cc:1046: RemoveMaterializedObjectsOnUnwind(frame);
As discussed offline: I think the materialized objects should only be
discarded if we didn't find an exception handler. Otherwise the
exception handler might lazy deopt and still need the materialized
objects.
https://codereview.chromium.org/1122083002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
