LGTM
Some JS style nits
https://codereview.chromium.org/1097283003/diff/220001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1097283003/diff/220001/src/parser.cc#newcode745
src/parser.cc:745: pos + 4, Variable::THIS);
I still want you to change the order of these params.
https://codereview.chromium.org/1097283003/diff/220001/src/parser.cc#newcode972
src/parser.cc:972: // context, which will have the "this" binding for
script scopes.
Might make sense. Also for module scopes there is no this binding.
https://codereview.chromium.org/1097283003/diff/220001/test/mjsunit/harmony/arrow-functions-this.js
File test/mjsunit/harmony/arrow-functions-this.js (right):
https://codereview.chromium.org/1097283003/diff/220001/test/mjsunit/harmony/arrow-functions-this.js#newcode11
test/mjsunit/harmony/arrow-functions-this.js:11: var globalSloppyArrow
= ()=>this;
no aligning of =
whitespace around =>
var globalSloppyArrow = () => this;
https://codereview.chromium.org/1097283003/diff/220001/test/mjsunit/harmony/arrow-functions-this.js#newcode17
test/mjsunit/harmony/arrow-functions-this.js:17: var strictFunctionArrow
= function(){ "use strict";
indent blocks two spaces
whitespace between ) and {
var strictFunctionArrow = function() {
"use strict";
return (() => this)();
};
https://codereview.chromium.org/1097283003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
