LGTM, Hr. Stub Writer,
   Lars

http://codereview.chromium.org/503042/diff/1/2
File bleeding_edge/src/heap.cc (right):

http://codereview.chromium.org/503042/diff/1/2#newcode2268
bleeding_edge/src/heap.cc:2268: ASSERT(object_size ==
JSObject::kHeaderSize + 2 * kPointerSize);
How about using a constant instead of retrieving it from the map. Keep
the ASSERT extracting the instance_size from the map.

http://codereview.chromium.org/503042/diff/1/3
File bleeding_edge/src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/503042/diff/1/3#newcode6647
bleeding_edge/src/ia32/codegen-ia32.cc:6647: ? FixedArray::kHeaderSize +
(length_ * kPointerSize)
FixedArray::SizeFor(length_)

http://codereview.chromium.org/503042

-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to