LGTM, but we should probably spend a few minutes looking at the code size impact of this change (seems to be +2.8% on V8 benchmarks).
http://codereview.chromium.org/502067/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/502067/diff/1/2#newcode841 src/ia32/codegen-ia32.cc:841: __ sar(left_, 1); 1 -> kSmiTagSize http://codereview.chromium.org/502067/diff/1/2#newcode843 src/ia32/codegen-ia32.cc:843: __ shl(left_, 1); 1 -> kSmiTagSize http://codereview.chromium.org/502067/diff/1/2#newcode869 src/ia32/codegen-ia32.cc:869: __ sar(right_, 1); 1 -> kSmiTagSize http://codereview.chromium.org/502067/diff/1/2#newcode871 src/ia32/codegen-ia32.cc:871: __ shl(right_, 1); 1 -> kSmiTagSize http://codereview.chromium.org/502067/diff/1/2#newcode888 src/ia32/codegen-ia32.cc:888: __ jmp(&done); Could this be a jmp(exit_label())? http://codereview.chromium.org/502067 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
