The non build system part look good. I'll give the other parts another look.
https://codereview.chromium.org/1129743003/diff/20001/tools/js2c.py
File tools/js2c.py (right):
https://codereview.chromium.org/1129743003/diff/20001/tools/js2c.py#newcode417
tools/js2c.py:417: filters = BuildExtraFilterChain if native_type ==
"EXTRA" else BuildFilterChain(macro_file, message_template_file)
Can we have a normal if-else here please? Would also keep this below 80
chars per col.
https://codereview.chromium.org/1129743003/diff/20001/tools/js2c.py#newcode577
tools/js2c.py:577: help="type parameter for NativesCollection template
(see NativeType enum)")
keeping 80 char limit would be nice.
https://codereview.chromium.org/1129743003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
