Updated the description. Thanks for the review.
https://codereview.chromium.org/1129823002/diff/1/src/preparser.h
File src/preparser.h (left):
https://codereview.chromium.org/1129823002/diff/1/src/preparser.h#oldcode2218
src/preparser.h:2218: scope_->RecordThisUsage();
On 2015/05/06 14:23:52, arv wrote:
It is not clear to me how this works now? Don't we use this
information to
determine if we should introduce a binding for this? Maybe we always
introduce a
this binding now (-arrows and eval)?
ThisExpression for the full parser will create an unresolved
VariableProxy which in Scope::Analyze() will be plugged to a Variable.
When that happens the Variable itself, wherever it is declared, will be
marked as used. The variable will also be marked as used if there is a
nested direct eval(), though perhaps those conditions are too
conservative (see Scope::MustAllocate()). Anyway, with all of that, the
flag is redundant.
https://codereview.chromium.org/1129823002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
