Everything else fixed.
http://codereview.chromium.org/506052/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/506052/diff/1/2#newcode7232 src/ia32/codegen-ia32.cc:7232: __ sub(ecx, Operand(scratch2)); On 2009/12/17 16:35:50, Lasse Reichstein wrote: > Complex rewrite: If you make ecx one larger here (loading immediate 31), and > then below increase shift_distance by one as well to shift out the sign bit out, > then the shr_cl further down will shift in a zero sign bit. This allows you to > drop the and_ with kMantissaMask. > (I think.) Nice idea, but it ruins the fast case for zero shift or zero answer, so I don't think it's worth it. http://codereview.chromium.org/506052 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
