Drive by review, but LGTM.
http://codereview.chromium.org/509001/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/509001/diff/1/2#newcode7446 src/ia32/codegen-ia32.cc:7446: __ j(greater, conversion_failure); Naming: If it's equal to too_big_exponent, it should be too big. Increase to_big_exponent by one, and use greater_equal. Also, it only bails out for too large exponents, not too small. If the input is a denormal, I have a hunch that the fisttp operation will set the denormal exception flag, which will need to be cleared. Maybe check that the exponent is in the range 0..63 (biased), perhaps by first checking if the exponent is less than zero and returning zero in that case. http://codereview.chromium.org/509001/diff/1/2#newcode7453 src/ia32/codegen-ia32.cc:7453: __ mov(ecx, Operand(esp, 0)); // Load low word of answer into ecx. pop(ecx) would be shorter (and then only drop one element below). http://codereview.chromium.org/509001 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
