https://codereview.chromium.org/1130283002/diff/80001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/1130283002/diff/80001/src/code-stubs.h#newcode1472
src/code-stubs.h:1472: CompareICStub(Isolate* isolate, Token::Value op,
bool strong,
On 2015/05/08 13:54:36, rossberg wrote:
Use LanguageMode here
After offline discussion, keeping bool for now. Will change binop to
follow this pattern later if no other objections.
https://codereview.chromium.org/1130283002/diff/80001/src/ic/ic.h
File src/ic/ic.h (right):
https://codereview.chromium.org/1130283002/diff/80001/src/ic/ic.h#newcode707
src/ic/ic.h:707: bool strong);
On 2015/05/08 13:54:36, rossberg wrote:
LanguageMode?
See above.
https://codereview.chromium.org/1130283002/diff/80001/src/ic/ic.h#newcode716
src/ic/ic.h:716: bool strong);
On 2015/05/08 13:54:36, rossberg wrote:
Same here
See above.
https://codereview.chromium.org/1130283002/diff/80001/src/runtime.js
File src/runtime.js (right):
https://codereview.chromium.org/1130283002/diff/80001/src/runtime.js#newcode21
src/runtime.js:21: var COMPARE;
On 2015/05/08 13:54:36, rossberg wrote:
Declare COMPARE_STRONG here
Done.
https://codereview.chromium.org/1130283002/diff/80001/src/runtime.js#newcode206
src/runtime.js:206: //Strong mode COMPARE throws if an implicit
conversion would be performed
On 2015/05/08 13:54:36, rossberg wrote:
Nit: space
Done.
https://codereview.chromium.org/1130283002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
