lgtm % comment
https://codereview.chromium.org/1134703002/diff/1/tools/testrunner/local/commands.py
File tools/testrunner/local/commands.py (right):
https://codereview.chromium.org/1134703002/diff/1/tools/testrunner/local/commands.py#newcode75
tools/testrunner/local/commands.py:75: process.kill()
This will raise exception if process is already dead. I think it should
be caught and maybe just 1 line to be printed.
This is my test on my Linux machine:
p = S.Popen(["cat", "~/.netrc"], stdout=S.PIPE, stderr=S.PIPE)
stdout, stderr = p.communicate()
'cat: ~/.netrc: No such file or directory\n'
p.kill()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python2.7/subprocess.py", line 1556, in kill
self.send_signal(signal.SIGKILL)
File "/usr/lib/python2.7/subprocess.py", line 1546, in send_signal
os.kill(self.pid, sig)
OSError: [Errno 3] No such process
https://codereview.chromium.org/1134703002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
