LGTM.
http://codereview.chromium.org/501170/diff/1/2 File src/heap.cc (right): http://codereview.chromium.org/501170/diff/1/2#newcode1613 src/heap.cc:1613: static inline int double_get_hash(double d) { This should really be DoubleGetHash (the same goes for the smi variant). http://codereview.chromium.org/501170/diff/1/2#newcode1616 src/heap.cc:1616: return (((value >> 16) ^ value)) How about adding another helper function so you can share the ((value >> 16) ^ value)) & (Heap::kNumberStrnigCacheSize - 1) code? (and maybe assert that Heap::kNumberStringCacheSize is a power of two) http://codereview.chromium.org/501170/diff/1/4 File src/heap.h (right): http://codereview.chromium.org/501170/diff/1/4#newcode824 src/heap.h:824: static const int kNumberStringCacheSize = 16384; How about 16 * KB or 16 * 1024? http://codereview.chromium.org/501170 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
