Reviewers: pfeldman_slow, kozyatinskiy, yurys,
Message:
Created Revert of Provide accessor for object internal properties that
doesn't
require debugger to be active
Description:
Revert of Provide accessor for object internal properties that doesn't
require
debugger to be active (patchset #3 id:40001 of
https://codereview.chromium.org/1126103006/)
Reason for revert:
GC mole issues:
https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gcmole/builds/1950/steps/GCMole%20ia32/logs/stdio
Original issue's description:
Provide accessor for object internal properties that doesn't require
debugger
to be active
Some of the DevTools' clients need to inspect JS objects without enabling
debugger. This CL allows to inspect object's internal properties without
enabling debugger and instantiating debug context.
Note that now debug context can be created lazily if
v8::Debug::GetDebugContext is called when there is no debug listener. This
is
fragile and has already resulted in some subtle error. I'm going to fix
that in
a separate CL.
BUG=chromium:481845
LOG=Y
Committed: https://crrev.com/bdeb0de88c8cf5f2c78f261b45314138f525110d
Cr-Commit-Position: refs/heads/master@{#28362}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:481845
Please review this at https://codereview.chromium.org/1133243002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+61, -201 lines):
M include/v8-debug.h
M src/api.cc
M src/bootstrapper.cc
M src/contexts.h
M src/mirror-debugger.js
M src/objects.h
M src/objects.cc
M src/runtime/runtime.h
M src/runtime/runtime-debug.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
