On 2015/05/06 11:53:13, titzer wrote:
...
Would it be possible to pull the integer range logic out to a separate
function
so that it can be tested simple integer ranges instead of requiring the
construction of types, etc? That would allow more exhaustive and more
efficient
unit testing, and allow us to apply the rules to machine-left shifts, too.
Yes this sounds good and improved testing performance. Note the test is
still
slow - more testing has been added. The test takes around 5 seconds here.
If you
can give me a realistic time then testing can be scaled to fit?
Also it was not clear how best to split this out. A new IntType was added
which
just has the int32_t limits for now, but might be extended with alignment or
known ones and zeros in future. If you could help get this patch through
then
I'll update the other patches to use the same style.
ptal.
https://codereview.chromium.org/1121573004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
